Skip to content

feat(linter): load custom JS plugins#11980

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/06-30-feat_linter_load_custom_js_plugins
Jul 8, 2025
Merged

feat(linter): load custom JS plugins#11980
graphite-app[bot] merged 1 commit intomainfrom
c/06-30-feat_linter_load_custom_js_plugins

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 30, 2025 •
edited
Loading

No description provided.

@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jun 30, 2025 •
edited by overlookmotel
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Jun 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11980 will not alter performance

Comparing c/06-30-feat_linter_load_custom_js_plugins (bde1ef1) with main (8814c53)

Summary

✅ 34 untouched benchmarks

@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch 2 times, most recently from fe3ca9b to a372299 Compare June 30, 2025 08:12
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Jun 30, 2025
@camc314 camc314 changed the base branch from main to graphite-base/11980 June 30, 2025 08:41
@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from a372299 to ded5bc6 Compare June 30, 2025 08:41
@camc314 camc314 changed the base branch from graphite-base/11980 to c/06-30-refactor_linter_remove_rulescache_ June 30, 2025 08:41
@camc314 camc314 mentioned this pull request Jun 30, 2025
Merged
@graphite-app graphite-app bot changed the base branch from c/06-30-refactor_linter_remove_rulescache_ to graphite-base/11980 June 30, 2025 08:47
@graphite-app graphite-app bot force-pushed the graphite-base/11980 branch from 1f2301d to 3f91f24 Compare June 30, 2025 08:50
@graphite-app graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from ded5bc6 to 3318c15 Compare June 30, 2025 08:50
@graphite-app graphite-app bot changed the base branch from graphite-base/11980 to main June 30, 2025 08:51
@graphite-app graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 3318c15 to 6694fb7 Compare June 30, 2025 08:51
@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch 4 times, most recently from bec71cb to dc201ac Compare July 3, 2025 09:01
@camc314 camc314 changed the base branch from main to graphite-base/11980 July 3, 2025 11:05
@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from dc201ac to 26612f5 Compare July 3, 2025 11:05
@camc314 camc314 changed the base branch from graphite-base/11980 to c/07-03-feat_linter_introduce_externallinter_struct July 3, 2025 11:05
This was referenced Jul 3, 2025
Merged
Merged
@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch 4 times, most recently from 7c6e7c5 to 78dd57a Compare July 3, 2025 17:05
@graphite-app graphite-app bot force-pushed the graphite-base/11980 branch from 3dc751e to 6ee645d Compare July 7, 2025 18:19
@graphite-app graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from fef9722 to 7b8da6c Compare July 7, 2025 18:19
@graphite-app graphite-app bot changed the base branch from graphite-base/11980 to main July 7, 2025 18:20
@graphite-app graphite-app bot force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 7b8da6c to 3a81b0d Compare July 7, 2025 18:20
@camc314
Copy link
Contributor Author

camc314 commented Jul 7, 2025

will fix

@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 3a81b0d to 2ab94af Compare July 7, 2025 19:37
@camc314 camc314 changed the base branch from main to graphite-base/11980 July 8, 2025 10:13
@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 2ab94af to 857ec43 Compare July 8, 2025 10:13
@camc314 camc314 changed the base branch from graphite-base/11980 to c/07-08-feat_linter_add_oxlint2___disable_oxlint2_feature_flags July 8, 2025 10:13
@camc314 camc314 mentioned this pull request Jul 8, 2025
Merged
@camc314 camc314 force-pushed the c/06-30-feat_linter_load_custom_js_plugins branch from 857ec43 to 5ddc751 Compare July 8, 2025 10:17
graphite-app[bot]
graphite-app bot reviewed Jul 8, 2025
View reviewed changes
@overlookmotel
Copy link
Member

overlookmotel commented Jul 8, 2025 •
edited
Loading

https://github.com/oxc-project/oxc/actions/runs/16141071434/job/45548482139?pr=11980#step:7:230

Huh? Looks like a match. Maybe a difference is whitespace / line breaks / invisible formatting characters?

@camc314
Copy link
Contributor Author

camc314 commented Jul 8, 2025

Ascii vs non-ascii i think, sent a msg on discord

@overlookmotel
Copy link
Member

overlookmotel commented Jul 8, 2025

The perf cost also looks quite high on oxc_linter benchmarks. Any guess what's causing it?

This was referenced Jul 8, 2025
Merged
Merged
Merged
overlookmotel
overlookmotel approved these changes Jul 8, 2025
View reviewed changes
napi/playground/Cargo.toml
oxc_napi = { workspace = true }

napi = { workspace = true }
napi = { workspace = true, features = ["async"] }
Copy link
Member

@overlookmotel overlookmotel Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can avoid this?

@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Jul 8, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
Copy link
Member

overlookmotel commented Jul 8, 2025 •
edited
Loading

I've got some suggested changes, but I'll do them as follow-up PRs.

This was referenced Jul 8, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@oxc-bot oxc-bot mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

No one assigned

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @overlookmotel @rakleed